Fix null values in older sdb, double-clicking on empty values #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
added
enhancement
eXpl0it3r
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that import to db doesnt work for 1297 because of null values in not null
area_polygoninclientmissions::MissionWaypointandmaterialsindbsounddata::ReverbMaterialConstraintin another sdb.Tried import on various versions and it worked without issues, so I didn't add default values for other types.
Copying empty values to clipboard on double click throws exception, so hyphen is copied instead.
Added
GlobalTypeMapper.Reset()because otherwise importing two different sdb files would fail on create schema due to duplicated mapping for custom types.